Merged
Conversation
bonnie57
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
bpolania,
edisonz0718 and
jacob-tucker
as code owners
DracoLi
reviewed
Feb 25, 2025
DracoLi
reviewed
Feb 25, 2025
DracoLi
reviewed
Feb 26, 2025
| } | ||
|
|
||
| /** | ||
| * Claims all revenue from the child IPs of an ancestor IP, then transfer. |
| }); | ||
| }); | ||
|
|
||
| it("should batch claim all revenue and convert WIP back to IP", async () => { |
Contributor
There was a problem hiding this comment.
and convert WIP back to IP this part isn't really tested in your assertions here. If possible, we should validate this, otherwise just remove this part so its clear we are not validating it.
Contributor
Author
There was a problem hiding this comment.
Agree. I noticed ClaimAllRevenue also doesn't validate, I will also remove it.
Contributor
There was a problem hiding this comment.
i remember it was hard to validate due to gas fees, if possible we should validate, but not very important imo.
Contributor
Author
There was a problem hiding this comment.
I agree with you. It's dynamic gas fees. I have removed the description of both.
DracoLi
reviewed
Feb 26, 2025
bonnie57
force-pushed
the
feat/batched-claim-all-revenue
branch
from
3dc0eee to
4ae4778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
batchClaimAllRevenuemethodroyaltymodule unit tests