Conversation
…atch registration and fee management
…hance fee call data construction in IpAccountBatchExecutor
…proved batch registration and fee management" This reverts commit d312881.
…ed derivative registration with parent IP license terms
…registration tests for derivatives in IPAssetClient
…utor for enhanced transaction customization
…AssetClient to validate error handling and successful registration scenarios
bonnie57
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
edisonz0718,
jacob-tucker,
limengformal and
lucas2brh
as code owners
…hod and update related tests for consistency
… that previous transactions will not be reverted if a request fails
Collaborator
|
There are 4 failed cases for |
Contributor
Author
No problem. I just think the error comes from the mintLicenseTokens method. I will change the amount to 1 to pass the integration tests. |
Collaborator
|
There are 4 failed cases for test . Please take a look when you have a chance again. @bonnie57 |
Contributor
Author
I don't have any change now. There's another thing I need to do. I'll let you know if I change it. @yingyangxu2026 |
Collaborator
|
Done |
yingyangxu2026
had a problem deploying
to
odyssey
GitHub Actions
Failure
yingyangxu2026
approved these changes
Jan 26, 2026
yingyangxu2026
temporarily deployed
to
odyssey
GitHub Actions
Inactive
lucas2brh
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
batchRegisterDerivativesmethod that supports automatic fee handling for both ERC20 and WIP tokensbatchRegisterDerivativemethod which lacks automatic fee handling supporttxOptionsparameter toIpAccountBatchExecutor.executeWithFeesto properly pass transaction options