Fix attribute_was to use ActiveModel::Dirty#7
Merged
Conversation
attribute_was was calling attribute_in_database which is an ActiveRecord-only method not available in ActiveModel::Dirty. Replace with changed_attributes lookup which is the correct ActiveModel::Dirty approach. Bump version to 0.0.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attribute_waswas callingattribute_in_databasewhich is an ActiveRecord-only method not available in ActiveModel::Dirty. This caused a NoMethodError for any consumer usingattribute_waswithout overriding it.Fix
Replace with
changed_attributes[attr_name.to_s]which is the correct ActiveModel::Dirty approach.Version
Bumps to 0.0.4.
Tests
Added specs for
attribute_was— returns previous value when changed, returns nil when unchanged.