Cleanups and speedups #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For public keys that are used to verify a single message, this provides no speed benefit, and requires the storage in memory of another GroupElement and its dblPrecmp. For public keys that are used to verify more than one message, the storage increase is the same, but the precomputation only occurs once now instead of during every verification.
…ods package private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various findbugs cleanups from zzz, and other fixes.
Several
FieldElementoperations have been sped up considerably, but they are still probably not constant time.GroupElementshould now be as close to constant time as ref10 is (aside from theFieldElementoperations).