chore(cleanup): P3 hygiene — delete dead test-scheduler-policy.ts + Notion path/tense fix#54
Merged
Merged
Conversation
Removed by PR #46's scheduler simplification — the A/B/C tier dispatch logic this module supported was dropped in favor of single-hourly free-only scheduling per DEC-20260503-B. The file itself was preserved in PR #46 to keep that diff tight; this is the immediate follow-up cleanup. Verified zero code imports across the repo before deletion. tsc clean post-delete. Notion to-do 35667c87-082c-81a394b7-d29956995283 (P3, Inbox). Companion edit (not in this commit): the Notion Testing system page (33c67c87-082c-8198-af5a-e667d78ef8fb) had a stale file path under "Key files" pointing at apps/api/src/lib/test-scheduler.ts. Corrected in Notion directly to apps/api/src/jobs/test-scheduler.ts and updated the surrounding tense from "being simplified" to past (PR #46 shipped the simplification 2026-05-04). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two P3 hygiene cleanups, scope tight. Item 3 (invoice-extract fixture) is held — see Open question below.
apps/api/src/lib/test-scheduler-policy.ts— dead since PR feat(scheduler): hourly free-only test schedule; drop A/B/C tier dispatch #46's scheduler simplification (DEC-20260503-B) but preserved to keep that diff tight. Verified zero code imports across the repo before deletion. To-do35667c87-082c-81a394b7-d29956995283.33c67c87-082c-8198-af5a-e667d78ef8fb) hadapps/api/src/lib/test-scheduler.tsunder "Key files" — wrong path; the file lives atapps/api/src/jobs/test-scheduler.ts. Edited directly in Notion + updated tense from "being simplified" to past (PR feat(scheduler): hourly free-only test schedule; drop A/B/C tier dispatch #46 shipped the work 2026-05-04). To-do35667c87-082c-8102-a944-c6e55d8f1366.Verification
npx tsc --noEmit --project apps/api/tsconfig.json— clean post-delete.test-scheduler-policyreturned 1 hit, in a handoff markdown narrative — no code imports.Per active protocols
Open question — item 3 deferred
Per the audit-first protocol I halted on item 3 (invoice-extract fixture is
httpbin.org/image/jpeg— a JPEG of a dog, not an invoice) because sourcing a real public-domain invoice fixture is non-trivial. The prod query Petter requested:returned 6 rows, all 6 with
external_cost_cents = 0,test_mode = 'live',active = true. Per Petter's branching logic, this puts item 3 in the PR #49 misclassification fix family — the suite is being scheduled hourly and bleeding Anthropic credits on a dog photo. Awaiting decision on whether to fix as: (a) reclassifyexternal_cost_cents > 0(scheduler-skip per DEC-20260503-B) + free-probe fixture, (b) real invoice fixture + hosting decision, or (c) drop scheduled run entirely. Tracked in to-do35667c87-082c-817f-9905-cfad380b8ae3.Test plan
rg test-scheduler-policyreturns only the handoff doc).apps/api/src/jobs/test-scheduler.ts.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com