Skip to content

chore(cleanup): P3 hygiene — delete dead test-scheduler-policy.ts + Notion path/tense fix#54

Merged
petterlindstrom79 merged 1 commit into
mainfrom
chore/p3-hygiene-cleanup-1-2
May 4, 2026
Merged

chore(cleanup): P3 hygiene — delete dead test-scheduler-policy.ts + Notion path/tense fix#54
petterlindstrom79 merged 1 commit into
mainfrom
chore/p3-hygiene-cleanup-1-2

Conversation

@petterlindstrom79
Copy link
Copy Markdown
Member

Summary

Two P3 hygiene cleanups, scope tight. Item 3 (invoice-extract fixture) is held — see Open question below.

Verification

  • npx tsc --noEmit --project apps/api/tsconfig.json — clean post-delete.
  • Repo-wide grep for test-scheduler-policy returned 1 hit, in a handoff markdown narrative — no code imports.
  • Notion edit confirmed (page content updated; only the one bullet changed).

Per active protocols

  • DEC-20260504-A: No new code paths introduced (a deletion + a doc edit). No regression test required.
  • DEC-20260504-B: Not a bulk-operation change.
  • DEC-20260504-C: Doesn't touch deploy mechanism.

Open question — item 3 deferred

Per the audit-first protocol I halted on item 3 (invoice-extract fixture is httpbin.org/image/jpeg — a JPEG of a dog, not an invoice) because sourcing a real public-domain invoice fixture is non-trivial. The prod query Petter requested:

SELECT id, test_type, test_mode, active, external_cost_cents
FROM test_suites WHERE capability_slug = 'invoice-extract'
ORDER BY test_type, id;

returned 6 rows, all 6 with external_cost_cents = 0, test_mode = 'live', active = true. Per Petter's branching logic, this puts item 3 in the PR #49 misclassification fix family — the suite is being scheduled hourly and bleeding Anthropic credits on a dog photo. Awaiting decision on whether to fix as: (a) reclassify external_cost_cents > 0 (scheduler-skip per DEC-20260503-B) + free-probe fixture, (b) real invoice fixture + hosting decision, or (c) drop scheduled run entirely. Tracked in to-do 35667c87-082c-817f-9905-cfad380b8ae3.

Test plan

  • Reviewer: confirm the deleted file has no imports anywhere in the repo (rg test-scheduler-policy returns only the handoff doc).
  • Reviewer: verify the Notion Testing system page "Key files" section reads apps/api/src/jobs/test-scheduler.ts.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Removed by PR #46's scheduler simplification — the A/B/C tier dispatch
logic this module supported was dropped in favor of single-hourly
free-only scheduling per DEC-20260503-B. The file itself was preserved
in PR #46 to keep that diff tight; this is the immediate follow-up
cleanup.

Verified zero code imports across the repo before deletion. tsc clean
post-delete. Notion to-do 35667c87-082c-81a394b7-d29956995283 (P3,
Inbox).

Companion edit (not in this commit): the Notion Testing system page
(33c67c87-082c-8198-af5a-e667d78ef8fb) had a stale file path under
"Key files" pointing at apps/api/src/lib/test-scheduler.ts. Corrected
in Notion directly to apps/api/src/jobs/test-scheduler.ts and updated
the surrounding tense from "being simplified" to past (PR #46 shipped
the simplification 2026-05-04).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@petterlindstrom79 petterlindstrom79 merged commit 7cb9302 into main May 4, 2026
1 check passed
@petterlindstrom79 petterlindstrom79 deleted the chore/p3-hygiene-cleanup-1-2 branch May 4, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant