Skip to content

docs(context): update offloader for TS availability#808

Merged
lizradway merged 4 commits intostrands-agents:mainfrom
lizradway:ts-offload
May 5, 2026
Merged

docs(context): update offloader for TS availability#808
lizradway merged 4 commits intostrands-agents:mainfrom
lizradway:ts-offload

Conversation

@lizradway
Copy link
Copy Markdown
Member

Description

Adds TS support availability for context offloader

Related Issues

strands-agents/sdk-typescript#974

Type of Change

  • Content update/revision

Checklist

  • I have read the CONTRIBUTING document
  • My changes follow the project's documentation style
  • I have tested the documentation locally using npm run dev
  • Links in the documentation are valid and working

@lizradway lizradway temporarily deployed to manual-approval May 4, 2026 18:14 — with GitHub Actions Inactive
@lizradway lizradway marked this pull request as ready for review May 4, 2026 18:16
@lizradway lizradway temporarily deployed to manual-approval May 4, 2026 18:16 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Documentation Preview Ready

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-808/docs/user-guide/quickstart/overview/

Updated at: 2026-05-05T14:58:20.249Z

Comment thread src/content/docs/user-guide/concepts/plugins/context-offloader.mdx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Assessment: Comment

Clean documentation update that correctly adds TypeScript tabs and removes the Python-only language restriction. The code examples follow proper conventions (camelCase TS APIs, correct Tab/Tabs usage, consistent formatting).

Review Notes
  • Consistency: One reference to the Python-only parameter name include_retrieval_tool=False remains in the Tradeoffs section prose (line 291) — should include the TS equivalent.
  • Type safety: Inline TypeScript examples won't be validated by the build system. Consider adding a .ts snippet file to match the pattern used by sibling pages (index.ts, skills.ts).

Overall a straightforward and well-structured addition. 👍

@lizradway lizradway marked this pull request as draft May 4, 2026 18:50
@lizradway lizradway marked this pull request as draft May 4, 2026 18:50
Comment thread src/content/docs/user-guide/concepts/plugins/context-offloader.ts Outdated
Comment thread src/content/docs/user-guide/concepts/plugins/context-offloader.mdx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Assessment: Comment

Good iteration — the TypeScript examples have been moved to snippet files (context-offloader.ts + context-offloader_imports.ts), addressing the prior review feedback. The snippet structure correctly uses block scopes for variable isolation and follows the established pattern.

Remaining Items
  • Consistency: The Tradeoffs section prose still mentions only include_retrieval_tool=False (Python) — needs the TS equivalent added (flagged in prior review, still open)
  • Cleanup: Unused declare const model: any in context-offloader.ts

Nice work moving to the snippet-based approach. 👍

@github-actions

This comment was marked as outdated.

@lizradway lizradway marked this pull request as ready for review May 4, 2026 20:44
Comment thread src/content/docs/user-guide/concepts/plugins/context-offloader.mdx Outdated
@lizradway lizradway requested a review from opieter-aws May 5, 2026 14:53
@lizradway lizradway temporarily deployed to manual-approval May 5, 2026 14:53 — with GitHub Actions Inactive
@lizradway lizradway merged commit 9867317 into strands-agents:main May 5, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants