Skip to content

Conversation

@davidpadbury
Copy link
Contributor

Description

Our app creates many MCP clients (multi user/tenant). Over time we saw a file descriptor leak and eventually tracked it down to the async-io event loop in the MCPClient not being closed.

Related Issues

N/A

Documentation PR

N/A

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mkmeral
mkmeral previously approved these changes Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

zastrowm
zastrowm previously approved these changes Dec 12, 2025
@davidpadbury davidpadbury dismissed stale reviews from zastrowm and mkmeral via 15f0ac7 December 12, 2025 13:57
@davidpadbury davidpadbury force-pushed the close-mcp-client-event-loop branch from 7ed8dd1 to 15f0ac7 Compare December 12, 2025 13:57
@github-actions github-actions bot added size/xs and removed size/xs labels Dec 12, 2025
@davidpadbury davidpadbury deployed to manual-approval December 12, 2025 13:57 — with GitHub Actions Active
@dbschmigelski
Copy link
Member

Mistral integ tests are failing. It appears they are having availability issues https://status.mistral.ai/

@dbschmigelski dbschmigelski enabled auto-merge (squash) December 12, 2025 15:59
@dbschmigelski dbschmigelski enabled auto-merge (squash) December 15, 2025 15:51
@dbschmigelski dbschmigelski merged commit 2a02388 into strands-agents:main Dec 15, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants