fix(citations): Preserve tagged union structure for CitationLocation #1343
+196
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes citation location handling in the Bedrock Converse API to properly preserve the tagged union structure required by the API.
Problem:
The Bedrock API requires
CitationLocationto be a tagged union with exactly one wrapper key (documentChar,documentPage, ordocumentChunk). The previous implementation was flattening the structure, causing validation errors:Solution:
*Innertypes + wrapper types for proper tagged union modeling_format_citation_locationhelper method to preserve the union structure when filteringBREAKING CHANGE:
CitationLocationtypes now use wrapper structure (e.g.,{"documentChar": {"documentIndex": 0, ...}}) instead of flat structure. This matches the actual Bedrock API specification and fixes the runtime error.Related Issues
Fixes #1323
Type of Change
Bug fix (breaking - but the previous behavior was incorrect and caused runtime errors)
Testing
hatch run prepare(1615 tests pass)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.