fix(bedrock): place cache point before non-PDF document blocks#2001
Open
kevmyung wants to merge 1 commit intostrands-agents:mainfrom
Open
fix(bedrock): place cache point before non-PDF document blocks#2001kevmyung wants to merge 1 commit intostrands-agents:mainfrom
kevmyung wants to merge 1 commit intostrands-agents:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1966
PR #1821 moved cache point injection from the last assistant message to the last user message. This causes a ValidationException when the last user message contains non-PDF document blocks (md, csv, txt, html), because Bedrock's format conversion fails to preserve the type field on a cachePoint block placed directly after a non-PDF document block.
In
_inject_cache_point, instead of unconditionally appending cachePoint to the end of the content array, scan for the first non-PDF document block and insert cachePoint before it. If no non-PDF document blocks exist, the existing behavior (append at end) is preserved.Cache effectiveness is not impacted — Anthropic's prompt caching is prefix-based, so placing cachePoint before the document block still includes the document content in the cached prefix.
Related Issues
#1966
#1821
Documentation PR
N/A
Type of Change
Bug fix
Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.