fix: isolate langfuse env vars#2022
Merged
lizradway merged 1 commit intostrands-agents:mainfrom Mar 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zastrowm
approved these changes
Mar 31, 2026
|
Assessment: Approve Clean, focused bug fix that correctly clears all three environment variables checked by the Review Summary
Nice minimal fix! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix tracer tests failing when developers have Langfuse environment variables set locally introduced in #1768
The
is_langfuseproperty checks three env vars (OTEL_EXPORTER_OTLP_ENDPOINT,OTEL_EXPORTER_OTLP_TRACES_ENDPOINT,LANGFUSE_BASE_URL), but themoto_envtest fixture only cleared the first one. When a developer has Langfuse configured locally, the remaining env vars leak into tests, causingis_langfuseto unexpectedly returnTrue. This triggers extraspan.set_attributes()calls that breakassert_called_once_withassertions.The fix adds
monkeypatch.delenvcalls forOTEL_EXPORTER_OTLP_TRACES_ENDPOINTandLANGFUSE_BASE_URLto themoto_envfixture, ensuring all three langfuse-related env vars are cleared for tests.Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change?
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.