fix(telemetry): remove force_flush in tracer#2142
Merged
poshinchen merged 1 commit intostrands-agents:mainfrom Apr 17, 2026
Merged
fix(telemetry): remove force_flush in tracer#2142poshinchen merged 1 commit intostrands-agents:mainfrom
poshinchen merged 1 commit intostrands-agents:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lizradway
reviewed
Apr 17, 2026
|
Assessment: Approve Clean, well-scoped bug fix that removes a synchronous Verification Notes
No concerns with this change. 👍 |
lizradway
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove force_flush in tracer.
Tracer._end_span()callstracer_provider.force_flush()synchronously after every span end. When the OTLP endpoint is unreachable, the exporter retries 6x with exponential backoff, blocking the calling thread. Multiple spans end per invocation (agent, event loop, model invoke, tool calls), so it compounds to ~90s total.Related Issues
#2138
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.