fix: correct MCPClient.__exit__ and stop() type annotations#2248
Open
cogwirrel wants to merge 2 commits intostrands-agents:mainfrom
Open
fix: correct MCPClient.__exit__ and stop() type annotations#2248cogwirrel wants to merge 2 commits intostrands-agents:mainfrom
cogwirrel wants to merge 2 commits intostrands-agents:mainfrom
Conversation
mehtarac
previously approved these changes
May 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
__exit__andstop()parameter types to match the context-manager protocol:exc_typeshould betype[BaseException] | None(notBaseException), and all params on__exit__need| None.Related Issues
Fixes #2247
Type of Change
Bug fix
Testing
uvx ty checkpasses (previously errored withinvalid-context-manager)pytest tests/strands/tools/mcp/test_mcp_client.py— 62 passedhatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.