Skip to content

fix: correct MCPClient.__exit__ and stop() type annotations#2248

Open
cogwirrel wants to merge 2 commits intostrands-agents:mainfrom
cogwirrel:read-python-ty-issue
Open

fix: correct MCPClient.__exit__ and stop() type annotations#2248
cogwirrel wants to merge 2 commits intostrands-agents:mainfrom
cogwirrel:read-python-ty-issue

Conversation

@cogwirrel
Copy link
Copy Markdown

Description

Fix __exit__ and stop() parameter types to match the context-manager protocol: exc_type should be type[BaseException] | None (not BaseException), and all params on __exit__ need | None.

Related Issues

Fixes #2247

Type of Change

Bug fix

Testing

  • uvx ty check passes (previously errored with invalid-context-manager)
  • pytest tests/strands/tools/mcp/test_mcp_client.py — 62 passed
  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mehtarac
mehtarac previously approved these changes May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MCPClient.__exit__ type annotations don't match context-manager protocol

2 participants