feat(telemetry): forward provider_kwargs to MeterProvider in setup_meter#2324
Open
aribault wants to merge 1 commit into
Open
feat(telemetry): forward provider_kwargs to MeterProvider in setup_meter#2324aribault wants to merge 1 commit into
aribault wants to merge 1 commit into
Conversation
setup_meter previously hard-coded the MeterProvider construction to only accept resource and metric_readers, forcing users who needed views, exemplar_filter, or shutdown_on_exit to bypass the helper entirely and reconstruct the provider from scratch. This change accepts arbitrary keyword arguments and forwards them, exposing the full MeterProvider surface without changing existing behavior. Resolves: strands-agents#843
0876564 to
35b98cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StrandsTelemetry.setup_meterconstructs an OpenTelemetryMeterProviderbut only forwardsresourceandmetric_readers. Users who need to pass other supportedMeterProviderkwargs, most notablyviews, currently have to bypasssetup_meterentirely and reconstruct the provider from scratch, as illustrated in the workaround the issue reporter shared.This change accepts arbitrary keyword arguments and forwards them to
MeterProvider, exposing the full surface without changing any existing behavior.Resolves: #843
Public API Changes
setup_meternow accepts**provider_kwargsthat are forwarded toMeterProvider.resourceandmetric_readerscontinue to be managed by the helper.Existing callers are unaffected.