chore: commit LICENSE and NOTICE directly into package directories#2392
Open
zastrowm wants to merge 1 commit into
Open
chore: commit LICENSE and NOTICE directly into package directories#2392zastrowm wants to merge 1 commit into
zastrowm wants to merge 1 commit into
Conversation
Instead of copying LICENSE and NOTICE from the repo root at build time via CI steps and prepack hooks, commit them directly into strands-py/ and strands-ts/. This simplifies the build process and lets contributors run local builds without extra setup.
awsarron
approved these changes
May 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Assessment: Approve Clean build simplification that removes CI-time file copying in favor of committed license files. The changes are consistent and well-tested. Review Notes
Nice improvement for local development ergonomics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of copying LICENSE and NOTICE from the repo root at build time via CI steps and prepack hooks, commit them directly into
strands-py/andstrands-ts/. This removes the build-time file-copy dance and lets contributors run local builds without extra setup.Resolves the local build ergonomics concern raised in #2384.
Related Issues
#2351, #2384
Type of Change
Other (please describe): Build simplification
Testing
Built Python wheel locally —
licenses/LICENSEandlicenses/NOTICEpresent,twine checkpassesRan
npm pack --dry-runfor TypeScript —LICENSE(10.1kB) andREADME.md(11.5kB) presentPre-commit hooks pass (TS build + full test suite)
I ran
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.