fix: remove unnecessary None from dict.get() calls #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ratish1
had a problem deploying
to
manual-approval
GitHub Actions
Failure
Ratish1
changed the title
Contributor
Author
|
Can someone PTAL, its just a simple fix. |
Ratish1
changed the title
Contributor
Author
|
Wanted to follow up on this, if someone could take a look, its just a simple fix. Thanks. |
dbschmigelski
previously approved these changes
Oct 31, 2025
Removes explicit 'None' default values from '.get()' calls in 'agent.py' and 'sagemaker.py'. The 'dict.get()' method defaults to 'None' already, so this change makes the code more concise and idiomatic without changing functionality.
Ratish1
force-pushed
the
cleanup/get-none-redundant
branch
from
6d27eba to
198b28a
Compare
Ratish1
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Contributor
Author
|
Hello @dbschmigelski, can this be approved, I know it might not be of much importance rn, but its just a really simple clean up . Thank you |
JackYPCOnline
approved these changes
Dec 17, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
@Ratish1 Could you rebase from main |
…nup/get-none-redundant
Ratish1
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Contributor
Author
Done |
dbschmigelski
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes explicit 'None' default values from '.get()' calls in 'agent.py' and 'sagemaker.py'.The 'dict.get()' method defaults to 'None' already, so this change makes explicitly passing None as the second argument
unnecessary.
Related Issues
N/ADocumentation PR
N/AType of Change
RefactorTesting
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.