Unify integ tests to run in browser & node #318
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
force-pushed
the
unify_integration_tests
branch
from
02eeb42 to
37bc8fd
Compare
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Rather than special casing the browser, run *all* integ tests in both browser & node by default, opting out when we need tests to run in only a single environment. For opting out, we now have two options: - For one off tests, use `skip: isInBrowser()` - For entire tests, use the file convention `thing.node.test.ts` and that will exclude it from browser tests This refactoring needed a bit of plumbing to make tests accommodate both environments, but I think it worked pretty well
zastrowm
force-pushed
the
unify_integration_tests
branch
from
37bc8fd to
882d743
Compare
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than special casing the browser, run all integ tests in both browser & node by default, opting out when we need tests to run in only a single environment.
For opting out, we now have two options:
skip: isInBrowser()thing.node.test.tsand that will exclude it from browser testsThis refactoring needed a bit of plumbing to make tests accommodate both environments, but I think it worked pretty well
Related Issues
Documentation PR
Type of Change
Refactor
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.