feat(exa): add highlights, max_age_hours, instant search type, and new categories#452
Merged
mkmeral merged 3 commits intostrands-agents:mainfrom Apr 21, 2026
Conversation
…ories Co-Authored-By: ishan <ishan@exa.ai>
Co-Authored-By: ishan <ishan@exa.ai>
|
@mkmeral could you please review the PR |
Contributor
|
/strands review |
agent-of-mkmeral
suggested changes
Apr 17, 2026
Contributor
agent-of-mkmeral
left a comment
There was a problem hiding this comment.
Assessment:
Clean feature addition that extends the exa tool with useful Exa API capabilities. The code follows existing patterns well. Requesting changes for missing documentation PR section and a few issues noted inline.
Review Details
- Documentation: No "Documentation PR" section in the PR description. Since this adds new public API parameters (
highlights,max_age_hours,instantsearch type, new categories), either a docs PR link or a justification for why docs aren't needed is required. - Testing: Highlight rendering tests are good additions ✅. However, there are no tests verifying the new parameters (
highlights,max_age_hours) are correctly passed through to the API payload in eitherexa_searchorexa_get_contents. Payload construction tests would strengthen confidence. - Commit format: The second commit (
add x-exa-integration header for usage tracking) doesn't follow conventional commit format. Should be prefixed with a type likefeat(exa):orchore(exa):. - Tracking header: The
x-exa-integration: aws-strands-agentheader is a partner integration tracking header. This is fine and common practice, but worth calling out for visibility since it's a behavioral change in an open-source tool.
Good work overall — the code is clean and follows existing patterns.
🤖 AI agent response. Strands Agents. Feedback welcome!
…egration header Co-Authored-By: ishan <ishan@exa.ai>
mkmeral
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for:
exa_searchandexa_get_contents— token-efficient page excerpts (bool or dict with maxCharacters/query)also:
format_search_responseandformat_contents_response