fix(middleware): exempt health probes from trusted-host check#3
Merged
Conversation
added 2 commits
July 2, 2026 21:18
- Add HealthExemptTrustedHostMiddleware to bypass validation only on /health and /ready. For ALB probes hitting the container by private IP - in prod we forbid wildcar on TRUSTED_HOSTS - Fix Docker build and broken login.css reference in the login template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Production deployments with a restricted
TRUSTED_HOSTS(no wildcard) were broken in two ways:ALB health probes rejected - target-group health checks reach the container via its private IP, so the
Hostheader is never inTRUSTED_HOSTS.TrustedHostMiddlewarereturns 400, the ALB marks the target unhealthy, and the service never becomes available. Fixed by introducingHealthExemptTrustedHostMiddlewarethat bypasses host validation only for/healthand/ready; all other requests remain strictly enforced.Docker build failing -
hatchlingrequiresLICENSEandREADME.mdto be present when building the wheel (both are declared inpyproject.toml). Neither was copied into the builder stage.Bonus fix:
login.htmlreferencedlogin.csswhich the Vite build never emits - changed to right one:index.cssRelated Issues
N/A
Type of Change
Testing
How have you tested the change?
uv run just check(lint + type check)uv run just testfor overall testingexamples/still workManual verification: started the container with
TRUSTED_HOSTSset to a specific hostname (no wildcard), confirmed/healthand/readyreturn 200 when hit by container IP, and confirmed all other paths with an untrustedHostheader still receive 400.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.