Skip to content

fix: address sync review feedback - #1995

Closed
stranske wants to merge 1 commit into
mainfrom
sync-review-1836-fix
Closed

fix: address sync review feedback#1995
stranske wants to merge 1 commit into
mainfrom
sync-review-1836-fix

Conversation

@stranske

@stranske stranske commented May 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • scope draft ready-for-review checks to explicit Tasks/Acceptance Criteria sections instead of unrelated PR-template checklists
  • restore repo-local follow-up acceptance filtering and Why-section hints for verifier follow-ups
  • correct label docs for verify:create-issue under the consolidated PR event hub

Validation

  • python -m pytest tests/test_followup_issue_generator.py -q
  • node --test .github/scripts/tests/keepalive-orchestrator-gate-runner.test.js
  • python scripts/validate_template_sync.py
  • git diff --check

Consumer review source: stranske/Pension-Data#364

Copilot AI review requested due to automatic review settings May 4, 2026 08:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@stranske
stranske temporarily deployed to agent-standard May 4, 2026 08:21 — with GitHub Actions Inactive
@stranske-keepalive

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 8e86fed
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 427be76714

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +130 to +131
} else if (section) {
section = '';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep counting checklist items across nested subheadings

When a draft PR body has a Tasks/Acceptance Criteria section that includes an internal heading (for example ### Phase 2 under #### Tasks), this branch clears section and stops collecting subsequent checkboxes, so unchecked items can be skipped and the PR can be auto-marked ready incorrectly. This is a real path because our parser explicitly allows subsection headers inside checklist sections (.github/scripts/issue_scope_parser.js notes that ### Phase 1 inside #### Tasks should remain content), so this logic can undercount unchecked work and bypass human routing.

Useful? React with 👍 / 👎.

@stranske

Copy link
Copy Markdown
Owner Author

Closing as superseded by current main. The actionable review concern on this branch was about section-scoped checklist counting across nested headings; current main no longer uses that section-reset approach for draft disposition and counts markdown checkboxes directly, so this stale dirty branch should not be merged.

@stranske stranske closed this May 14, 2026
@stranske
stranske deleted the sync-review-1836-fix branch May 14, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants