fix: address sync review feedback - #1995
Conversation
Automated Status SummaryHead SHA: 8e86fed
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 427be76714
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else if (section) { | ||
| section = ''; |
There was a problem hiding this comment.
Keep counting checklist items across nested subheadings
When a draft PR body has a Tasks/Acceptance Criteria section that includes an internal heading (for example ### Phase 2 under #### Tasks), this branch clears section and stops collecting subsequent checkboxes, so unchecked items can be skipped and the PR can be auto-marked ready incorrectly. This is a real path because our parser explicitly allows subsection headers inside checklist sections (.github/scripts/issue_scope_parser.js notes that ### Phase 1 inside #### Tasks should remain content), so this logic can undercount unchecked work and bypass human routing.
Useful? React with 👍 / 👎.
|
Closing as superseded by current main. The actionable review concern on this branch was about section-scoped checklist counting across nested headings; current main no longer uses that section-reset approach for draft disposition and counts markdown checkboxes directly, so this stale dirty branch should not be merged. |
Summary
Validation
Consumer review source: stranske/Pension-Data#364