Skip to content

Conversation

@gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Feb 24, 2022

As proposed in strapi/strapi#12213 this PR introduces a size prop for SimpleMenu, to decrease the padding of the trigger button. The default (size=M) stays the same as it is.

Screenshots

ℹ️ I've added the background manually to display the difference. It won't be visible by default (on hover/ focus only).

Screenshot 2022-02-24 at 12 57 07

Demo

https://design-system-git-feat-simple-menu-small-strapijs.vercel.app/?path=/story/design-system-components-simplemenu--sizes

@vercel
Copy link

vercel bot commented Feb 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

design-system – ./

🔍 Inspect: https://vercel.com/strapijs/design-system/9i2AWaioRcs4XM2QysbGq91AZ7H9
✅ Preview: https://design-system-git-feat-simple-menu-small-strapijs.vercel.app

design-system-website – ./website

🔍 Inspect: https://vercel.com/strapijs/design-system-website/C6t2Bz6FgcwmQ7fk78yK5RXTh11A
✅ Preview: https://design-system-website-git-feat-simple-menu-small-strapijs.vercel.app

@gu-stav
Copy link
Contributor Author

gu-stav commented Feb 25, 2022

@HichamELBSI Thanks for the review again. I think everything you suggested makes sense. Before merging this, I'd like to talk with @maevalienard on Monday, because this change would need to be reflected in Figma too (I guess).

@HichamELBSI
Copy link
Collaborator

@HichamELBSI Thanks for the review again. I think everything you suggested makes sense. Before merging this, I'd like to talk with @maevalienard on Monday, because this change would need to be reflected in Figma too (I guess).

Sure! I'll convert this PR as Draft then (for the moment) 👍🏽

@maevalienard
Copy link
Contributor

Can we add to the StoryBook documentation the purpose of the S size SimpleMenu? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement This PR adds or updates some part of the codebase or features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants