-
Notifications
You must be signed in to change notification settings - Fork 198
SimpleMenu: Add size prop and define small size #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). design-system – ./🔍 Inspect: https://vercel.com/strapijs/design-system/9i2AWaioRcs4XM2QysbGq91AZ7H9 design-system-website – ./website🔍 Inspect: https://vercel.com/strapijs/design-system-website/C6t2Bz6FgcwmQ7fk78yK5RXTh11A |
277d0b3 to
fbdfd7e
Compare
|
@HichamELBSI Thanks for the review again. I think everything you suggested makes sense. Before merging this, I'd like to talk with @maevalienard on Monday, because this change would need to be reflected in Figma too (I guess). |
Sure! I'll convert this PR as Draft then (for the moment) 👍🏽 |
|
Can we add to the StoryBook documentation the purpose of the S size SimpleMenu? :) |
b0b50ce to
92af50a
Compare
92af50a to
57625d6
Compare
57625d6 to
87c1b70
Compare
87c1b70 to
69c3cb5
Compare
As proposed in strapi/strapi#12213 this PR introduces a
sizeprop forSimpleMenu, to decrease the padding of the trigger button. The default (size=M) stays the same as it is.Screenshots
ℹ️ I've added the background manually to display the difference. It won't be visible by default (on hover/ focus only).
Demo
https://design-system-git-feat-simple-menu-small-strapijs.vercel.app/?path=/story/design-system-components-simplemenu--sizes