-
Notifications
You must be signed in to change notification settings - Fork 198
Flex Component: Add gap prop
#583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). design-system-website – ./website🔍 Inspect: https://vercel.com/strapijs/design-system-website/ELwBsBxztFYGvPeAYEw8zH7zcw6N design-system – ./🔍 Inspect: https://vercel.com/strapijs/design-system/2jTBqUrSFeWS4mRWpynEZjtEe9u9 |
|
Thanks also for this PR. I really like it, but need to confirm |
|
Thank you, flex gap would be great! Our Grid component already does this, it allows: WDYT? |
72f6b6f to
043b286
Compare
043b286 to
62eda40
Compare
HichamELBSI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MattieBelt, thanks for the contribution 😄
|
Not sure why but I had to "Approve and run" for the tests to run. |
|
@MattieBelt You'll need to update the storyshots. |
HichamELBSI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Add
gapprop to Flex ComponentDescription
Use theme spaces to set the flex property
gapon your Flex component.Demo
Example on : https://design-system-7r256h8ex-strapijs.vercel.app/?path=/story/design-system-technical-components-flex--base
API
Discussion
gapalso allow responsive properties just like the padding props in the Box component?