Skip to content

[Dark mode] Memorize mode #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ronronscelestes merged 2 commits into from
Mar 23, 2022
Merged

[Dark mode] Memorize mode #586

ronronscelestes merged 2 commits into from
Mar 23, 2022

Conversation

@ronronscelestes
Copy link
Contributor

@ronronscelestes ronronscelestes commented Mar 21, 2022

What

  • Fixed mode chosen not memorized
  • Refacto Theme component used in preview.js
  • Added window.matchMedia to test-bundler.js ➡️
  • Needed to use import { useDarkMode } from 'storybook-dark-mode' in Theme component

How to test

  • Launch Storybook
  • Change mode
  • Switch to a different story, reload the page
  • It should memorize your mode chosen
  • Shouldn't break dark mode e2e tests

@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

design-system – ./

🔍 Inspect: https://vercel.com/strapijs/design-system/77MeEcKLbWH3b6p45TyZJ3bbL7wg
✅ Preview: https://design-system-git-dark-mode-memorize-mode-strapijs.vercel.app

design-system-website – ./website

🔍 Inspect: https://vercel.com/strapijs/design-system-website/41LKbaKjQBUcoqv6ZEYSoQ2VZPBe
✅ Preview: https://design-system-website-git-dark-mode-memorize-mode-strapijs.vercel.app

HichamELBSI
HichamELBSI requested changes Mar 23, 2022
View reviewed changes
@HichamELBSI HichamELBSI self-assigned this Mar 23, 2022
@HichamELBSI HichamELBSI added the pr: chore This PR contains chore tasks (cleanups, configs, tooling...) label Mar 23, 2022
@HichamELBSI HichamELBSI added this to the 1.1.0 milestone Mar 23, 2022
HichamELBSI
HichamELBSI approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronronscelestes ronronscelestes merged commit d796d7c into main Mar 23, 2022
@ronronscelestes ronronscelestes deleted the dark-mode/memorize-mode branch March 23, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HichamELBSI HichamELBSI HichamELBSI approved these changes

@gu-stav gu-stav Awaiting requested review from gu-stav

Assignees

@HichamELBSI HichamELBSI

Labels

pr: chore This PR contains chore tasks (cleanups, configs, tooling...)

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ronronscelestes @HichamELBSI