Move vertical stack from Box to Flex with direction set to column #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). design-system – ./🔍 Inspect: https://vercel.com/strapijs/design-system/HKVVnwyoXAZZ8FEmiUH8TMCN6NrJ design-system-website – ./website🔍 Inspect: https://vercel.com/strapijs/design-system-website/9YzM2zzC7RYxvC816wViTpMnq1wF |
HichamELBSI
added
the
pr: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move vertical stack from Box to Flex with direction set to column
Align-items set to stretch to keep previous UI behavior
Why
See DS Jira ticket DS-14
Will allow StackV to handle flex props (align-items, justify-content)
Remove some needs to customize Stack with styled-props
Snapshot