Move sizeLimit one level above in upload provider #1133

Marc-Roig · 2022-09-15T13:59:14Z

What does it do?

Updates in the upload plugin Guide:

Add migration guide for the next minor release.
Update of "Max file size" in upload plugin.

Related issue(s)/PR(s)

vercel · 2022-09-15T13:59:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
documentation	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 1, 2023 at 3:23PM (UTC)
documentation-docu-mvp	❌ Failed (Inspect)			Feb 1, 2023 at 3:23PM (UTC)

strapi-cla · 2022-09-15T13:59:18Z

All committers have signed the CLA.

Marc-Roig · 2022-09-15T15:47:05Z

I added a new migration file explaining:

people should move the sizeLimit configuration (if being used)
also be careful if the sizeLimit value was in kilobytes.

What do you think?

gpene

👍

pwizla

Thank you very much and congrats for your very first PR to our documentation repo, @Marc-Roig! 🥳
Good job.
I added some suggestions, those are mostly formatting-related. Happy to help if you have any questions. 🤗

...er-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md

…uides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>

…-limit-in-bytes

The base branch was changed.

…-limit-in-bytes

Marc-Roig · 2023-02-01T15:20:59Z

Sorry for the wait , this will now be ready to merge in 4.6.1 .
I have moved the migration steps to the migration-guid-4.5.1-to-4.6.1.md file, introduced in #1430.

So we will have to merge that PR first ⚠️

pwizla

LGTM now. Thanks again, Marc!

* user-permissions plugin: document how to add Patreon as an Oauth provider * add server webhooks populateRelations config variable * Update docs/developer-docs/latest/setup-deployment-guides/configurations/required/server.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Auto stash before merge of "dev/webhook-populated-relations" and "origin/dev/webhook-populated-relations" * add 4.6.1 migration guide * Update docs/developer-docs/latest/setup-deployment-guides/configurations/required/server.md Co-authored-by: Pierre Noël <petersg83@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.5.1-to-4.6.1.md Co-authored-by: Pierre Noël <petersg83@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.5.1-to-4.6.1.md Co-authored-by: Pierre Noël <petersg83@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.5.1-to-4.6.1.md Co-authored-by: Pierre Noël <petersg83@users.noreply.github.com> * improve explanation of webhooks populate relations usage * Update filtering-locale-publication.md (#1441) for this pull strapi/strapi#15046 * Fix deployment instructions for Azure CLI # Change 1: Update Node runtime argument of ```az webapp create``` Running the docs as-is produces an error: ```... Linux Runtime 'node|10.14' is not supported.Run 'az webapp list-runtimes --os-type linux' to cross check``` The correct parameter today is ```bash --runtime "node|14-lts" ``` # Change 2: Update IP address block arguments of ```az mysql server firewall-rule create``` Running the docs as-is produces an error: ```... the following arguments are required: --start-ip-address, --end-ip-address``` Based on [the most recent docs](https://learn.microsoft.com/en-us/cli/azure/mysql/server/firewall-rule?view=azure-cli-latest), the correct parameters to define the allowed IP blocks are: ```bash --start-ip-address 0.0.0.0 --end-ip-address 0.0.0.0 ``` * Change Node 14 to Node 16 https://azure.microsoft.com/en-us/updates/community-support-for-node-14-lts-is-ending-on-30-april-2023/ * Update docs/developer-docs/latest/plugins/users-permissions.md * Update docs/developer-docs/latest/plugins/users-permissions.md * Fix broken links reported in issue #1423 (#1484) * Fix broken links reported in issue #1423 * Fix BE custom. > middlewares link * Update quick-start.md (#1478) * Move sizeLimit one level above in upload provider (#1133) * move sizeLimit one level above in upload provider * add sizeLimit deprecation warning * minor change * minor change * checkFileSize upload provider * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update docs/developer-docs/latest/update-migration-guides/migration-guides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * move migration steps to 4.5.1 to 4.6.1 --------- Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * update localhost link * Connect can not be used for media attributes (#1490) * connect can not be used for meida attributes * change warning to caution --------- Co-authored-by: Tom Shortall <tomshortall@gmail.com> Co-authored-by: Marc-Roig <marc12info@gmail.com> Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> Co-authored-by: Pierre Noël <petersg83@users.noreply.github.com> Co-authored-by: Jorge Martin <53431308+HastaCs@users.noreply.github.com> Co-authored-by: Antti <antti.viitala@icloud.com> Co-authored-by: Shaun Brown <97027841+StrapiShaun@users.noreply.github.com> Co-authored-by: Pierre Wizla <pwizla+github@gmail.com> Co-authored-by: katekosm <71697829+katekosm@users.noreply.github.com>

Marc-Roig added 2 commits September 15, 2022 15:49

move sizeLimit one level above in upload provider

e106dfb

add sizeLimit deprecation warning

d3ae2b7

minor change

f0a77b4

vercel bot deployed to Preview September 15, 2022 14:01 View deployment

vercel bot deployed to Preview September 15, 2022 14:04 View deployment

minor change

7bb333b

Marc-Roig changed the title ~~(WIP) Move sizeLimit one level above in upload provider~~ Move sizeLimit one level above in upload provider Sep 15, 2022

Marc-Roig marked this pull request as ready for review September 15, 2022 15:44

Marc-Roig requested review from alexandrebodin and pwizla September 15, 2022 15:45

vercel bot deployed to Preview September 15, 2022 15:45 View deployment

stb13579 assigned gpene Sep 16, 2022

gpene previously approved these changes Sep 16, 2022

View reviewed changes

stb13579 added this to the 4.3.9 milestone Sep 16, 2022

checkFileSize upload provider

34561f3

vercel bot deployed to Preview September 16, 2022 09:16 View deployment

pwizla requested changes Sep 16, 2022

View reviewed changes

Marc-Roig and others added 5 commits September 16, 2022 15:40

Update docs/developer-docs/latest/update-migration-guides/migration-g…

4c2ebb6

…uides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>

Update docs/developer-docs/latest/update-migration-guides/migration-g…

660f05f

…uides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>

Update docs/developer-docs/latest/update-migration-guides/migration-g…

18ebdf5

…uides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>

Update docs/developer-docs/latest/update-migration-guides/migration-g…

0ed68eb

…uides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>

Update docs/developer-docs/latest/update-migration-guides/migration-g…

c416606

…uides/v4/migration-guide-4.3.x-to-4.4.x.md Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>

pwizla added this to the 4.5.2 milestone Nov 16, 2022

pwizla added the internal PRs created by the Strapi core team label Nov 30, 2022

pwizla modified the milestones: 4.5.3, 4.6.0-beta.1, 4.5.4 Nov 30, 2022

pwizla modified the milestones: 4.5.4, 4.5.5 Dec 14, 2022

stb13579 removed this from the 4.5.5 milestone Dec 27, 2022

pwizla added this to the 4.6.1 milestone Jan 24, 2023

Marc-Roig added 3 commits February 1, 2023 16:09

Merge branch 'main' into dev/provider-size-limit-in-bytes

67c3202

Merge branch 'dev/webhook-populated-relations' into dev/provider-size…

cdf7d36

…-limit-in-bytes

move migration steps to 4.5.1 to 4.6.1

a5c44ce

Marc-Roig changed the base branch from main to dev/webhook-populated-relations February 1, 2023 15:15

vercel bot deployed to Preview – documentation February 1, 2023 15:18 View deployment

vercel bot had a problem deploying to Preview – documentation-docu-mvp February 1, 2023 15:18 Failure

Merge branch 'dev/webhook-populated-relations' into dev/provider-size…

f02e884

…-limit-in-bytes

Marc-Roig requested a review from pwizla February 1, 2023 15:21

vercel bot deployed to Preview – documentation February 1, 2023 15:23 View deployment

vercel bot had a problem deploying to Preview – documentation-docu-mvp February 1, 2023 15:23 Failure

pwizla approved these changes Feb 6, 2023

View reviewed changes

pwizla merged commit 942f2ef into dev/webhook-populated-relations Feb 6, 2023

pwizla deleted the dev/provider-size-limit-in-bytes branch February 6, 2023 16:55

pwizla added the replicate with docu label Feb 8, 2023

pwizla added a commit that referenced this pull request Feb 8, 2023

Backport #1133 to Docusaurus

bc9682d

pwizla removed the replicate with docu label Feb 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move sizeLimit one level above in upload provider #1133

Move sizeLimit one level above in upload provider #1133

Uh oh!

Marc-Roig commented Sep 15, 2022 •

edited

Loading

Uh oh!

vercel bot commented Sep 15, 2022 •

edited

Loading

Uh oh!

strapi-cla commented Sep 15, 2022 •

edited

Loading

Uh oh!

Marc-Roig commented Sep 15, 2022

Uh oh!

gpene left a comment

Uh oh!

pwizla left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Marc-Roig commented Feb 1, 2023

Uh oh!

pwizla left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Move sizeLimit one level above in upload provider #1133

Move sizeLimit one level above in upload provider #1133

Uh oh!

Conversation

Marc-Roig commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does it do?

Related issue(s)/PR(s)

Uh oh!

vercel bot commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

strapi-cla commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marc-Roig commented Sep 15, 2022

Uh oh!

gpene left a comment

Choose a reason for hiding this comment

Uh oh!

pwizla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Marc-Roig commented Feb 1, 2023

Uh oh!

pwizla left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Marc-Roig commented Sep 15, 2022 •

edited

Loading

vercel bot commented Sep 15, 2022 •

edited

Loading

strapi-cla commented Sep 15, 2022 •

edited

Loading