Skip to content

Improve 'Create a plugin' steps #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2023
Merged

Improve 'Create a plugin' steps #1446

merged 2 commits into from
Jan 25, 2023

Conversation

@stb13579
Copy link
Contributor

@stb13579 stb13579 commented Jan 24, 2023

This PR addresses user feedback by explicitly declaring that the plugins.js or plugins.ts file needs to be created manually by the developer.

@stb13579 stb13579 added source: Dev Docs PRs/issues targeting the Developer Docs pr: updated content PRs updating existing documentation content internal PRs created by the Strapi core team target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch). size: small If the PR includes only 1 file with <10 lines of text or a small code fix labels Jan 24, 2023
@stb13579 stb13579 self-assigned this Jan 24, 2023
@vercel
Copy link

vercel bot commented Jan 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
documentation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 10:38AM (UTC)
documentation-docu-mvp ❌ Failed (Inspect) Jan 25, 2023 at 10:38AM (UTC)

@pwizla
Copy link
Collaborator

pwizla commented Jan 25, 2023

Thanks, Shaun. I believe step 6 is optional since, if I'm not mistaken, it already exists if a plugin was created or added to Strapi. Apart from that, LGTM.

pwizla
pwizla reviewed Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for "(optional)" as mentioned in the comment (to be tested/checked)

@stb13579 stb13579 requested a review from pwizla January 25, 2023 10:37
pwizla
pwizla approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@stb13579 stb13579 merged commit 74244c5 into main Jan 25, 2023
@stb13579 stb13579 deleted the plugins-config-fix branch January 25, 2023 11:19
@pwizla pwizla added this to the 4.6.0 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pwizla pwizla pwizla approved these changes

@meganelacheny meganelacheny Awaiting requested review from meganelacheny meganelacheny is a code owner

Assignees

@stb13579 stb13579

Labels

internal PRs created by the Strapi core team pr: updated content PRs updating existing documentation content size: small If the PR includes only 1 file with <10 lines of text or a small code fix source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch).

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stb13579 @pwizla