Align public middleware example with maxAge configuration#3149
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pwizla
reviewed
May 13, 2026
pwizla
added a commit
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2324.
The option table for \strapi::public\ only documents \maxAge, but the sample block used \defer\ and \index, which does not match what Strapi 5 pulls from this middleware \config\ (see \packages/core/core/src/middlewares/public.ts). I updated both JavaScript and TypeScript examples to set \maxAge\ only and added a short note that the key stays camelCase and lines up with how the core forwards the value to \koa-static.
Made with Cursor