Skip to content

Make Inki review verify docs against the strapi PR they document#3305

Merged
pwizla merged 1 commit into
mainfrom
repo/inki-review-detect-upstream-strapi-pr
Jun 30, 2026
Merged

Make Inki review verify docs against the strapi PR they document#3305
pwizla merged 1 commit into
mainfrom
repo/inki-review-detect-upstream-strapi-pr

Conversation

@pwizla

@pwizla pwizla commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

This PR makes /inki:review detect when a strapi/documentation PR description references a strapi/strapi or strapi/cloud code PR (e.g. strapi/strapi#26737) and verify the documentation against that code PR's head instead of develop or a possibly-stale local clone. The target resolver now reads the PR body and exposes the referenced code PRs, the code-verifier treats the referenced PR as its primary source of truth so an unmerged change is no longer flagged as a nonexistent config key or value, and the coherence checker uses it to tell a real contradiction apart from a sibling page that has not been updated yet.

…t it

When a strapi/documentation PR description references a strapi/strapi or strapi/cloud code PR, /inki:review now detects it and verifies the docs against that PR's head instead of develop or a possibly-stale local clone. This prevents false 'config key/value does not exist' findings when the documented code change is still unmerged, and lets the coherence checker tell a real contradiction apart from a sibling page that simply has not been updated yet.
@pwizla pwizla self-assigned this Jun 30, 2026
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
documentation Ready Ready Preview, Comment Jun 30, 2026 2:30pm

Request Review

@github-actions github-actions Bot added pr: chore source: repo PRs/issues not targeting a specific documentation but rather affecting the whole repo labels Jun 30, 2026

@pwizla pwizla left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's go! Should fix some review errors I noticed today

@pwizla pwizla added the pr: updated content PRs updating existing documentation content label Jun 30, 2026
@pwizla pwizla added this to the 7.0.1 milestone Jun 30, 2026
@pwizla pwizla merged commit 8f5be39 into main Jun 30, 2026
7 of 8 checks passed
@pwizla pwizla deleted the repo/inki-review-detect-upstream-strapi-pr branch June 30, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: chore pr: updated content PRs updating existing documentation content source: repo PRs/issues not targeting a specific documentation but rather affecting the whole repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant