Conversation
🦋 Changeset detectedLatest commit: a3ede8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
we seem to have a lint issue, but lgtm! |
innerdvations
left a comment
There was a problem hiding this comment.
LGTM, but when you fix the build/test issue, can you investigate if that means this could potentially cause problems downstream? I think it should be fine since pack-up is only used by sdk-plugin at this point, and that shouldn't be a major issue, but just want to be sure
|
Thanks for the reviews, the CI failure is fixed now. The plan will be to merge this, release a patch in pack up, update the pack up dependency in sdk plugin and then release a patch there |
|



What does it do?
Update vite dependency
Working towards resolving:
strapi/sdk-plugin#92
The longer term plan is to completely remove pack up from SDK plugin - it's the only Strapi repo that still uses the package
In progress in the sdk-plugin - but will likely require a major version bump of the sdk plugin.
Updating the vite dependency here will allow us to release a secure patch of both pack up and sdk plugin