Skip to content

chore: update vite dependency#35

Merged
jhoward1994 merged 4 commits intomainfrom
chore/vite-version-bump
Dec 19, 2025
Merged

chore: update vite dependency#35
jhoward1994 merged 4 commits intomainfrom
chore/vite-version-bump

Conversation

@jhoward1994
Copy link
Contributor

@jhoward1994 jhoward1994 commented Dec 18, 2025

What does it do?

Update vite dependency

Working towards resolving:
strapi/sdk-plugin#92

The longer term plan is to completely remove pack up from SDK plugin - it's the only Strapi repo that still uses the package

In progress in the sdk-plugin - but will likely require a major version bump of the sdk plugin.

Updating the vite dependency here will allow us to release a secure patch of both pack up and sdk plugin

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: a3ede8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jhoward1994 jhoward1994 self-assigned this Dec 18, 2025
Bassel17
Bassel17 previously approved these changes Dec 19, 2025
@Bassel17
Copy link
Member

we seem to have a lint issue, but lgtm!

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but when you fix the build/test issue, can you investigate if that means this could potentially cause problems downstream? I think it should be fine since pack-up is only used by sdk-plugin at this point, and that shouldn't be a major issue, but just want to be sure

@jhoward1994
Copy link
Contributor Author

Thanks for the reviews, the CI failure is fixed now.

The plan will be to merge this, release a patch in pack up, update the pack up dependency in sdk plugin and then release a patch there

innerdvations
innerdvations previously approved these changes Dec 19, 2025
@sonarqubecloud
Copy link

@jhoward1994 jhoward1994 merged commit 072a770 into main Dec 19, 2025
5 checks passed
@jhoward1994 jhoward1994 deleted the chore/vite-version-bump branch December 19, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants