Support for type alias in LExprT (temporary fix, if needed)#39
Merged
Conversation
atomb
reviewed
Aug 13, 2025
atomb
previously approved these changes
Aug 13, 2025
Contributor
atomb
left a comment
atomb
left a comment
There was a problem hiding this comment.
I think this seems reasonable, though I'm not deeply familiar with the code involved.
andrewmwells-amazon
suggested changes
Aug 14, 2025
Co-authored-by: Andrew Wells <130512013+andrewmwells-amazon@users.noreply.github.com>
Co-authored-by: Andrew Wells <130512013+andrewmwells-amazon@users.noreply.github.com>
Co-authored-by: Andrew Wells <130512013+andrewmwells-amazon@users.noreply.github.com>
andrewmwells-amazon
approved these changes
Aug 14, 2025
Contributor
|
There is a disabled test in here that I think was broken because of lack of type alias support in unification. It's probably worth checking if this fixes that test and if not, updating the comment to reflect it isn't related. |
atomb
approved these changes
Aug 14, 2025
samuelchassot
added a commit
that referenced
this pull request
Aug 15, 2025
*Description of changes:* This test was commented out because of missing type aliases support, but with PR #39, it works. Also, I added a label to the assertion, otherwise the `.smt2` filename is too long and is rejected by `z3`. I will file an issue. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
keyboardDrummer-bot
added a commit
that referenced
this pull request
May 6, 2026
Save prepends before processing arguments so that: 1. Argument side-effects execute first (defining snapshot variables) 2. Outer prepends (from sibling expressions) execute next (defining their snapshot variables that the call may reference) 3. The lifted call executes last (after all referenced variables exist) Also uncomments the addProcCaller test case. The correct assertion value is 15 (not 14): addProc(1,11)=12, plus (x:=3)=3, total 15. Closes #39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds supports for Type aliases in type annotations on LExpr. Ideally, we'd like to parametrized LExpr on the type of type annotations, to let users write LExpr with LTy, and have LExpr with only LMonoTy later in the type analysis and partial evaluation.
This PR fixes the bug in case we need a temporary fix.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.