Skip to content

Add documentation generation for Laurel#434

Merged
keyboardDrummer merged 28 commits intomainfrom
remy/laurelDocs
Feb 23, 2026
Merged

Add documentation generation for Laurel#434
keyboardDrummer merged 28 commits intomainfrom
remy/laurelDocs

Conversation

@keyboardDrummer
Copy link
Contributor

@keyboardDrummer keyboardDrummer commented Feb 17, 2026

Changes

  • Add documentation for Laurel

Testing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@keyboardDrummer keyboardDrummer marked this pull request as ready for review February 18, 2026 11:06
@keyboardDrummer keyboardDrummer requested a review from a team as a code owner February 18, 2026 11:06
tautschnig
tautschnig previously approved these changes Feb 18, 2026
Copy link
Contributor

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving of the general direction, but I have a number of questions/suggestion for refinement.

Co-authored-by: Michael Tautschnig <mt@debian.org>
keyboardDrummer and others added 7 commits February 18, 2026 13:02
Co-authored-by: Michael Tautschnig <mt@debian.org>
Co-authored-by: Michael Tautschnig <mt@debian.org>
Co-authored-by: Michael Tautschnig <mt@debian.org>
Co-authored-by: Michael Tautschnig <mt@debian.org>
Co-authored-by: Michael Tautschnig <mt@debian.org>
@keyboardDrummer keyboardDrummer removed the request for review from andrewmwells-amazon February 18, 2026 19:47
@joscoh
Copy link
Contributor

joscoh commented Feb 18, 2026

Overall looks good, most of my questions are about the actual language definition rather than the documentation. Could be useful to have an example program in the documentation though.

tautschnig
tautschnig previously approved these changes Feb 19, 2026
Copy link
Contributor

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tautschnig
Copy link
Contributor

@copilot Please review.

joscoh
joscoh previously approved these changes Feb 19, 2026
Copy link
Contributor

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

@keyboardDrummer keyboardDrummer added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 1221d67 Feb 23, 2026
15 checks passed
@keyboardDrummer keyboardDrummer deleted the remy/laurelDocs branch February 23, 2026 20:50
atomb pushed a commit that referenced this pull request Feb 23, 2026
### Changes
- Add documentation for Laurel

### Testing
- Locally looked at the generated docs. After merging this should become
available on https://strata-org.github.io/Strata/

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

---------

Co-authored-by: Michael Tautschnig <mt@debian.org>
Co-authored-by: Andrew Wells <130512013+andrewmwells-amazon@users.noreply.github.com>
Co-authored-by: Joe Hendrix <joehx@amazon.com>
fabiomadge added a commit that referenced this pull request Feb 24, 2026
Merged commits: f6ff88b, a6e5f93, 64fd6d6, 6f67113, 9dccebf,
a0716de, 1221d67, d1c7ddd, cb2411d

Conflict resolutions:
- IntBoolFactory.lean: took HEAD (has full function set + DivT/ModT).
  Added intSafeDivFunc/intSafeModFunc with preconditions (PR #444).
  Added Inhabited constraint to IntBoolFactory.
- SMTEncoder.lean: added main's SafeMod + DivT/ModT SMT encodings.
- LaurelToCoreTranslator.lean: took HEAD logic, wrapped init RHS
  values in `some` for PR #432's Cmd.init signature change.
- Laurel.lean: took main's version (PR #434 docstrings), then
  restored branch-specific changes: preconditions (list) in Procedure,
  postconditions (list) in Body.Opaque/Abstract, removed Determinism,
  added deriving Repr on WithMetadata and HighType, added Repr
  instance for Imperative.MetaData.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants