Parse and lift the SMT counterexamples to LExpr#495
Merged
Conversation
…paceSepBy, which seems to be only used by SMTDDM
atomb
previously approved these changes
Feb 27, 2026
shigoel
reviewed
Mar 2, 2026
shigoel
reviewed
Mar 2, 2026
shigoel
reviewed
Mar 2, 2026
shigoel
reviewed
Mar 2, 2026
shigoel
reviewed
Mar 2, 2026
shigoel
reviewed
Mar 2, 2026
shigoel
reviewed
Mar 2, 2026
…be represented in Strata.SMT.Term. Avoid propagating the error to the top-level StrataVerify.
Contributor
Author
|
Fixed the latest failure after #496 by updating DDM's Parser to also correspondingly recognize '$'. :) |
shigoel
approved these changes
Mar 3, 2026
atomb
approved these changes
Mar 3, 2026
kondylidou
pushed a commit
to abdoo8080/Strata
that referenced
this pull request
Mar 5, 2026
This patch - Parses the output of SMT solver containing counterexample using SMTDDM, - Lifts SMTDDM.Term to SMT.Term, then to LExpr, and - Let Core.verify properly print the counterexample using the new printer of Core. To implement this, - A new `parseCategoryFromDialect` function is added to DDM. It parses a string using a specific syntax category. - A bug in SpaceSepBy making only odd'th symbols to be parsed was fixed. It seems SpaceSepBy was only used by SMTDDM. - The old CexParser.lean is erased. A new StrataTest/Languages/Core/CounterExampleLiftTest.lean test shows a handful of interesting results. --- strata-org#482 and this pull request have overlapping edits. Merging strata-org#482 does not introduce merge conflict, but tests need updates. Would be great if strata-org#482 is reviewed first! :) --- Thanks to Kiro :) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch
To implement this,
parseCategoryFromDialectfunction is added to DDM. It parses a string using a specific syntax category.A new StrataTest/Languages/Core/CounterExampleLiftTest.lean test shows a handful of interesting results.
#482 and this pull request have overlapping edits. Merging #482 does not introduce merge conflict, but tests need updates. Would be great if #482 is reviewed first! :)
Thanks to Kiro :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.