Fix pySpecs path handling to avoid unnormalized paths#692
Merged
Conversation
When sourceDir had a trailing slash, FilePath's `/` operator produced double-slash paths (e.g. `src//boto3`). After stripping the prefix the remainder started with `/`, creating absolute output paths that bypassed the output directory entirely. Rewrite pySpecOutputPath to use `dropPrefix?` and explicitly validate the separator slash, so trailing-slash variation in sourceDir no longer matters. Also promote path-derivation and metadata failures from per-module soft errors to hard throws, since they indicate internal bugs rather than user-recoverable problems. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joscoh
approved these changes
Mar 27, 2026
shigoel
approved these changes
Mar 27, 2026
olivier-aws
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Summary Fix a bug where paths were getting an extra slash (e.g., `a//b`) and this caused output paths to become absolute, failing with permission errors. - Rewrite path stripping to handle trailing-slash variations correctly - Promote internal path failures to hard errors instead of silently skipping modules Verified on pyspec files. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where paths were getting an extra slash (e.g.,
a//b) and this caused output paths to become absolute, failing with permission errors.Verified on pyspec files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.