feat: Add an exec command to submit AP to a test workcell#193
feat: Add an exec command to submit AP to a test workcell#193scottyantipa merged 22 commits intomasterfrom
Conversation
scottyantipa
force-pushed
the
SA-wc-submit
branch
from
2f97223 to
991fc51
Compare
| ) | ||
| @click.option( | ||
| "--workcellId", | ||
| "-wc", |
There was a problem hiding this comment.
I think we use -w for submit.py. Do we want to be coherent?
| try: | ||
| res_json = json.loads(res.content) | ||
| if res_json["success"]: | ||
| print("Success. View dashboard for scheduling job.") |
There was a problem hiding this comment.
Maybe putting the url with the correct port can be nice. as we have to add the :9000
On another note, can we redirect to 9000 automatically in the lab repo that would be great :D
yangchoo
left a comment
yangchoo
left a comment
There was a problem hiding this comment.
Bunch of minor nits.
If you don't mind, could you add tests to test/cli_test.py and/or test/commands/.._test.py?
Trying to be good citizens about increasing test coverage here for new tests.
| pass | ||
|
|
||
|
|
||
| @cli.command("exec") |
There was a problem hiding this comment.
we probably want to limit this by feature group. See @cli.command("submit", ...)
yangchoo
left a comment
yangchoo
left a comment
There was a problem hiding this comment.
Almost there!
Thanks for adding the tests.
Please also add your changes to CHANGELOG.rst and kebab-case options
scottyantipa
force-pushed
the
SA-wc-submit
branch
from
5409383 to
19a62c4
Compare
|
@yangchoo ok this is finally ready |
yangchoo
left a comment
yangchoo
left a comment
There was a problem hiding this comment.
Thanks! Almost all done.
Pretty minor nit in terms of scoping exec under some feature flag.
| commands.format(manifest) | ||
|
|
||
|
|
||
| @cli.command("exec") |
There was a problem hiding this comment.
nit: we probably want to limit this by feature group. See @cli.command("submit", ...)
There was a problem hiding this comment.
discussed offline
|
Added workcell format validation |
yangchoo
left a comment
yangchoo
left a comment
There was a problem hiding this comment.
lgtm. When merging, please ensure we have a readable final commit message.
3 participants
No description provided.