Setting organization id in the request headers#198
Merged
ramu-phanimukla merged 11 commits intomasterfrom Mar 9, 2021
Merged
Conversation
added 2 commits
March 4, 2021 23:05
dzleidig
reviewed
Mar 8, 2021
dzleidig
reviewed
Mar 8, 2021
dzleidig
reviewed
Mar 8, 2021
yangchoo
previously approved these changes
Mar 9, 2021
Contributor
yangchoo
left a comment
yangchoo
left a comment
There was a problem hiding this comment.
Seems reasonable. Some nits, but generally looks good.
yangchoo
previously approved these changes
Mar 9, 2021
Contributor
yangchoo
left a comment
yangchoo
left a comment
There was a problem hiding this comment.
lgtm, thanks for addressing the comments!
dzleidig
previously approved these changes
Mar 9, 2021
Contributor
dzleidig
left a comment
dzleidig
left a comment
There was a problem hiding this comment.
Lgtm. As I mentioned on slack, usually we have a separate PR for the version bump / release. This is what Yang instructed me to do when we released the bearer token auth changes.
…request header" This reverts commit 4f824f7
dzleidig
approved these changes
Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strateos web API, going forward, will enforce passing new request header parameter
X-Organization-Id, this library must pass in all the requests.