Skip to content

feature: handle new frontend deployment for frontend#204

Merged
GregoryEssertel merged 12 commits intomasterfrom
GE-fix-new-frontend-url
May 27, 2021
Merged

feature: handle new frontend deployment for frontend#204
GregoryEssertel merged 12 commits intomasterfrom
GE-fix-new-frontend-url

Conversation

@GregoryEssertel
Copy link
Copy Markdown
Contributor

@GregoryEssertel GregoryEssertel commented May 24, 2021

Summary:
The frontend url (lab.core.strateos.com/haven/wctest) is not the same that the url to the frontend node. This would be confusing to user to have to use different one.

The exec method will request the frontend server for the IP of the frontend node, and then make the request to it.

$ transcriptic preview Read | transcriptic exec --api http://lab.core.strateos.com/haven/wctest
Sending request to 13.52.223.111:9000
Success. View http://lab.core.strateos.com/haven/wctest/dashboard to see the scheduling outcome.

Comment thread transcriptic/commands.py
@@ -1489,6 +1489,25 @@ def execute(
partition_horizon,
partitioning_swap_device_id,
):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. You could also support (or not?) https. I don't think we have the requirement to support it, but you could also warn if the user accidentally uses https protocol.

scottyantipa
scottyantipa previously approved these changes May 27, 2021
@GregoryEssertel GregoryEssertel merged commit 06c21b6 into master May 27, 2021
@GregoryEssertel GregoryEssertel deleted the GE-fix-new-frontend-url branch May 27, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants