feature: handle new frontend deployment for frontend#204
Merged
GregoryEssertel merged 12 commits intomasterfrom May 27, 2021
Merged
feature: handle new frontend deployment for frontend#204GregoryEssertel merged 12 commits intomasterfrom
GregoryEssertel merged 12 commits intomasterfrom
Conversation
| @@ -1489,6 +1489,25 @@ def execute( | |||
| partition_horizon, | |||
| partitioning_swap_device_id, | |||
| ): | |||
Contributor
There was a problem hiding this comment.
Seems good. You could also support (or not?) https. I don't think we have the requirement to support it, but you could also warn if the user accidentally uses https protocol.
scottyantipa
previously approved these changes
May 27, 2021
scottyantipa
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The frontend url (lab.core.strateos.com/haven/wctest) is not the same that the url to the frontend node. This would be confusing to user to have to use different one.
The exec method will request the frontend server for the IP of the frontend node, and then make the request to it.