Put str_id macro into a separate module#428
Merged
mergify[bot] merged 3 commits intostratis-storage:masterfrom Mar 1, 2019
Merged
Put str_id macro into a separate module#428mergify[bot] merged 3 commits intostratis-storage:masterfrom
mergify[bot] merged 3 commits intostratis-storage:masterfrom
Conversation
mulkieran
force-pushed
the
master-ids
branch
from
de8130d to
1dff55a
Compare
mulkieran
force-pushed
the
master-ids
branch
5 times, most recently
from
ea252ea to
ada5a65
Compare
For better modularity. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
master-ids
branch
from
ada5a65 to
243bd62
Compare
No longer pass as an argument to str_id macro. I think str_check was defined originally as a function because we were novice macro users. That function was always passed for construction of the type, it was used exclusively for that purpose, and it seems unlikely that it will need to be varied. Have str_check just evaluate to an Option<String> rather than a Result. Promote the Option to the error in str_id. Removes duplication and isolates the use of the DmResult type to two places. Signed-off-by: mulhern <amulhern@redhat.com>
So that the tests are near the things they test. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
master-ids
branch
from
243bd62 to
142a5d1
Compare
trgill
approved these changes
Feb 26, 2019
tasleson
approved these changes
Mar 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better modularity.