Skip to content

libcryptsetup-rs v0.13.0#431

Merged
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:libcryptsetup-rs-version-0.13.0
May 21, 2025
Merged

libcryptsetup-rs v0.13.0#431
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:libcryptsetup-rs-version-0.13.0

Conversation

@mulkieran
Copy link
Copy Markdown
Member

@mulkieran mulkieran commented May 20, 2025

@mulkieran mulkieran self-assigned this May 20, 2025
@mulkieran mulkieran moved this to In Progress in 2025May May 20, 2025
@mulkieran mulkieran moved this from In Progress to In Review in 2025May May 20, 2025
@mulkieran mulkieran marked this pull request as ready for review May 20, 2025 22:08
@mulkieran mulkieran requested a review from jbaublitz May 20, 2025 22:08
Copy link
Copy Markdown
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably add a reference to the other change.

Comment thread CHANGES.txt Outdated
Comment on lines +6 to +8
- Add additional valid options to CryptVolumeKeyHandle::get:
https://github.com/stratis-storage/libcryptsetup-rs/pull/428
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR had two separate changes in it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

included...

@mulkieran mulkieran force-pushed the libcryptsetup-rs-version-0.13.0 branch from ede2304 to d960911 Compare May 21, 2025 15:16
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran merged commit 7317ee6 into stratis-storage:master May 21, 2025
39 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2025May May 21, 2025
@mulkieran mulkieran deleted the libcryptsetup-rs-version-0.13.0 branch May 21, 2025 16:06
@mulkieran mulkieran moved this from Done to Done(3) in 2025May May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(3)

Development

Successfully merging this pull request may close these issues.

2 participants