Skip to content

Try alternative branches for tests that use non-stratisd repos #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mulkieran merged 1 commit into from
Jun 16, 2025
Merged

Try alternative branches for tests that use non-stratisd repos #3858

mulkieran merged 1 commit into from
Jun 16, 2025

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Jun 12, 2025 •
edited
Loading

@mulkieran mulkieran self-assigned this Jun 12, 2025
@mulkieran mulkieran moved this to In Progress in 2025June Jun 12, 2025
@packit-as-a-service
Copy link

packit-as-a-service bot commented Jun 12, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3858
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

2 similar comments
@packit-as-a-service
Copy link

packit-as-a-service bot commented Jun 12, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3858
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Jun 12, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3858
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran force-pushed the project_issue_755 branch from 471023e to e222410 Compare June 12, 2025 13:26
@mulkieran
Copy link
Member Author

mulkieran commented Jun 12, 2025

Even though both branch checkouts failed, the condition for both checkout succeeding passed. This is very strange.

@mulkieran mulkieran force-pushed the project_issue_755 branch from e222410 to 7fe32f7 Compare June 12, 2025 13:31
@mulkieran
Copy link
Member Author

mulkieran commented Jun 12, 2025

This one is working...

@mulkieran mulkieran force-pushed the project_issue_755 branch 3 times, most recently from 387e197 to 5347b28 Compare June 12, 2025 20:37
@mulkieran mulkieran changed the title Project issue 755 Try alternative branches for tests that use non-stratisd repos Jun 12, 2025
@mulkieran mulkieran force-pushed the project_issue_755 branch from 5347b28 to adf821b Compare June 12, 2025 20:40
@mulkieran mulkieran marked this pull request as ready for review June 12, 2025 20:42
@mulkieran mulkieran moved this from In Progress to In Review in 2025June Jun 12, 2025
@mulkieran mulkieran force-pushed the project_issue_755 branch 5 times, most recently from 7e51b34 to 16f633e Compare June 12, 2025 21:07
@mulkieran
Copy link
Member Author

mulkieran commented Jun 12, 2025

ref value is expanding to 3858/merge which is not what is wanted.

@mulkieran mulkieran force-pushed the project_issue_755 branch from 16f633e to 26dff9b Compare June 12, 2025 22:23
@mulkieran
Try alternative branches for tests that use non-stratisd repos
26dff9b 
In case a change has to be made to the other repo so that this PR
compiles, this should ensure that the branch that addresses the problem
is automatically used instead of the default branch.

The branch name for the external repos is exactly the branch name for
the PR.

Also install git for checkout action, so that the checkout action  doesn't
have to fall back to the GitHub API.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran requested a review from jbaublitz June 13, 2025 01:54
@mulkieran
Copy link
Member Author

mulkieran commented Jun 13, 2025

Packit test failures can be ignored...

jbaublitz
jbaublitz approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Are you planning to just do this for stratis-cli for the time being? I feel like libcryptsetup-rs/libblkid-rs/etc. will be harder as they're Rust packages and it involves changing the Cargo.toml in Github Actions. I'm not even sure what it would take in packit.

@mulkieran
Copy link
Member Author

mulkieran commented Jun 16, 2025

Approved. Are you planning to just do this for stratis-cli for the time being? I feel like libcryptsetup-rs/libblkid-rs/etc. will be harder as they're Rust packages and it involves changing the Cargo.toml in Github Actions. I'm not even sure what it would take in packit.

This is for stratis-cli and for testing repos. For our Rust dependencies...it will have to be a Rust solution. I'm not sure yet what we could do with Cargo.toml to make that work. It's possible that cargo add will help.

@mulkieran mulkieran merged commit 589af14 into stratis-storage:master Jun 16, 2025
43 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025June Jun 16, 2025
@mulkieran mulkieran deleted the project_issue_755 branch June 16, 2025 12:00
@mulkieran mulkieran moved this from Done to Done(2) in 2025June Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaublitz jbaublitz jbaublitz approved these changes

Assignees

@mulkieran mulkieran

Labels

None yet

Projects

No open projects
2025June
Status: Done(2)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mulkieran @jbaublitz