Skip to content

Fix Node stats#331

Merged
quantumagi merged 3 commits intostratisproject:masterfrom
quantumagi:fixnodestats
Jan 4, 2021
Merged

Fix Node stats#331
quantumagi merged 3 commits intostratisproject:masterfrom
quantumagi:fixnodestats

Conversation

@quantumagi
Copy link
Copy Markdown
Contributor

@quantumagi quantumagi commented Jan 4, 2021 •
edited
Loading

See https://stratisplatformuk.visualstudio.com/HPI/_workitems/edit/5344/.

  • Uses a separate string builder for each component.
  • Moves everything in under the lock.
  • Bonus: Since we're now using separate string builders we can add Parallel.ForEach.

@quantumagi quantumagi requested a review from fassadlr January 4, 2021 06:46
fassadlr
fassadlr approved these changes Jan 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@fassadlr fassadlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE.

@quantumagi quantumagi merged commit c9835a5 into stratisproject:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fassadlr fassadlr fassadlr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quantumagi @fassadlr