The pin_distributor_removes_closed_outputs test (pre-existing in crates/engine/src/tests/pin_distributor.rs) only asserts the open output still receives packets. It does not verify the closed output was actually removed from the actor's internal routing.
A misbehaving actor could ignore the closed connection entirely, or attempt sends without removing it, and the test would still pass.
Suggested fix: Observe the outputs gauge, or assert the actor processes a subsequent packet without a warning storm from the closed-output path, or document why the current assertion is sufficient.
Found during review of PR #427.
The
pin_distributor_removes_closed_outputstest (pre-existing incrates/engine/src/tests/pin_distributor.rs) only asserts the open output still receives packets. It does not verify the closed output was actually removed from the actor's internal routing.A misbehaving actor could ignore the closed connection entirely, or attempt sends without removing it, and the test would still pass.
Suggested fix: Observe the outputs gauge, or assert the actor processes a subsequent packet without a warning storm from the closed-output path, or document why the current assertion is sufficient.
Found during review of PR #427.