Skip to content

MoQ pull: runtime codec mismatch should update output pin or fail connection #454

@staging-devin-ai-integration

Description

Summary

When catalog discovery during initialize() fails or times out, the MoQ pull node keeps the constructor's default out pin type (typically Opus). If run_connection() later discovers a different catalog audio codec, it currently only logs a warning (#429 fix in #453) but continues sending packets with the mismatched codec on the out pin.

This means downstream nodes still see the original pin PacketType, not the runtime-discovered one, potentially routing e.g. AAC data into an Opus decoder.

Expected Behavior

The node should either:

  1. Update the advertised pin type through the engine's pin-update mechanism before emitting packets, or
  2. Fail/reconnect the connection when the runtime codec is incompatible with the registered out pin

Context

Found during review of #453. The warning added in that PR (#429) makes the mismatch observable, but does not resolve the underlying contract violation.

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions