fix(ci): download ONNX Runtime from Microsoft instead of pyke.io CDN#364
Merged
Conversation
The ort-sys build script downloads ONNX Runtime binaries from cdn.pyke.io, which is intermittently unreliable (HTTP 504/522 errors). This breaks the Plugins / Lint jobs for the simple and sherpa groups whenever the CDN is down. Pre-download ONNX Runtime from Microsoft's official GitHub releases and set ORT_LIB_LOCATION so the ort-sys build script uses the pre-downloaded library, completely bypassing the pyke.io CDN. Ref: pykeio/ort#395 Signed-off-by: StreamKit Devin <devin@streamkit.dev> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Plugins / Lint (simple)andPlugins / Lint (sherpa)CI jobs fail becauseort-sys v2.0.0-rc.10's build script downloads ONNX Runtime binaries fromcdn.pyke.io, which is currently returning HTTP 504 (Gateway Timeout). This is a known recurring issue with the pyke.io CDN.Affected plugins:
whisper,sensevoice,parakeet(all depend onort = "2.0.0-rc.10")Fix: Pre-download ONNX Runtime v1.22.0 from Microsoft's official GitHub releases (highly reliable) and set
ORT_LIB_LOCATIONso theort-sysbuild script uses the pre-downloaded library, completely bypassing the pyke.io CDN. The download is cached between CI runs to avoid re-downloading on every build.Review & Testing Checklist for Human
Plugins / Lint (simple)andPlugins / Lint (sherpa)CI jobs pass on this PRwhisper,sensevoice, andparakeetNotes
ONNXRUNTIME_VERSIONenv var (1.22.0) matches the version embedded inort-sys v2.0.0-rc.10— if theortdependency is ever upgraded, this version should be updated to match.nllbandservogroups are unaffected (noortdependency) and unchanged.Link to Devin session: https://staging.itsdev.in/sessions/41a4153313204dceb2ca98abd548de2c
Requested by: @streamer45