-
Notifications
You must be signed in to change notification settings - Fork 0
feat(mcp): add generate_oneshot_command tool #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
streamer45
merged 4 commits into
devin/1776979022-mcp-server
from
devin/1777059757-generate-oneshot-command
Apr 24, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
448b1c6
feat(mcp): add generate_oneshot_command tool
streamkit-devin 5bffb28
fix(mcp): fix duplicate --input flags and add shell quoting
streamkit-devin ad33ad8
fix(mcp): shell-quote field names in skit-cli command generator
streamkit-devin 5fca7ed
fix(mcp): use dynamic heredoc delimiter to prevent content injection
streamkit-devin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 skit-cli command sends duplicate input when no 'media' field exists
When no input has field name
"media", thegenerate_skit_cli_commandfunction uses the first input's path as the CLI's required positionalinputargument (which the CLI always maps to field"media"perapps/skit-cli/src/main.rs:366), and then also emits ALL inputs as--input field=pathflags (lines 688-692). This means the first input file is sent twice: once as"media"(positional) and once with its actual field name. The comment at line 670-671 acknowledges this is intentional to ensure the server receives the correct field name, but the extra"media"multipart part is spurious and could confuse pipelines that don't expect it. Whether this causes a runtime error depends on how the oneshot engine handles unexpected input fields — worth verifying.Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
Playground
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation. This is a known limitation of the skit-cli's design — the positional
inputarg always maps to the"media"field internally. When the user's pipeline uses a different field name, the generated command necessarily sends the file twice: once as the positional (mapped to "media") and once via--inputwith the correct field name. The oneshot engine ignores unrecognized input fields, so the extra "media" part is harmless but redundant. A cleaner solution would require a CLI change to accept the positional input's field name — out of scope for this PR but worth considering.