Conversation
Co-authored-by: Copilot <copilot@github.com>
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions (notably code-colors, nano-theme, and thingies), updates the runtime CDN URL used to load the code-colors bundle, and simplifies/removes some styling behaviors in the default theme/styles.
Changes:
- Bump
code-colorsto^2.5.0and update the CDN bundle URL accordingly. - Remove
selectionfrom the exportedColorPalettetype and remove related::selectionstyling and other token-decoration styles. - Re-export
utilfrom the package entrypoint and fix a React hook dependency list inMarkup.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Lockfile updates for bumped dependencies. |
| package.json | Bumps code-colors, nano-theme, and thingies versions. |
| src/util.ts | Updates bundle CDN URL to code-colors@2.5.0 on jsDelivr. |
| src/index.ts | Exposes util module via public exports. |
| src/Markup.ts | Adds lang to useEffect dependency array. |
| src/style.ts | Removes selection from palette type and drops several styling rules (including ::selection). |
| src/palettes.ts | Removes selection values from light/dark palettes to match updated type. |
| README.md | Minor markdown formatting cleanup. |
| CHANGELOG.md | Markdown list formatting cleanup. |
| .github/workflows/gh-pages.yml | Minor YAML formatting change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export interface ColorPalette { | ||
| mono1: string; | ||
| mono2?: string; | ||
| mono3?: string; | ||
| col1?: string; | ||
| col2?: string; | ||
| col3?: string; | ||
| col4?: string; | ||
| col5?: string; | ||
| col6?: string; | ||
| negative?: string; | ||
| positive?: string; | ||
| selection: string; | ||
| string?: string; | ||
| keyword?: string; | ||
| builtin?: string; |
There was a problem hiding this comment.
Removing the exported selection field from ColorPalette is a breaking TypeScript API change for consumers that construct ColorPalette object literals (it will now fail excess-property checks). If the intent is to stop supporting selection styling, consider keeping selection?: string for backwards compatibility (even if unused), or bump the major version and clearly document the breaking change.
| export * from "./palettes"; | ||
| export * from "./ColorTokens"; | ||
| export * from "./Markup"; | ||
| export * from "./util"; |
There was a problem hiding this comment.
export * from "./util" makes colors()/tokens() part of the library’s public API surface. If that’s not intended, avoid re-exporting this module. If it is intended, consider documenting it (and its CDN/network dependency) as a supported API, since it will be harder to change later without a breaking release.
| export * from "./util"; |
No description provided.