Mutxt element fixes#1031
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses MuTxt UI styling issues by refining scoped reset behavior, font loading, element margins, and icon coloring.
Changes:
- Centralizes Google Fonts injection and enables it for scoped reset usage.
- Adjusts MuTxt block margins from prior reset-sensitive keys to nano-theme margin shorthand.
- Fixes several icon/color and overlay styling details.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/4-card/ContextMenu/ContextPane.tsx | Adds default text color for context panes. |
| packages/nano-theme/src/scoped-reset.ts | Revises scoped reset selectors and loads fonts for scoped mode. |
| packages/nano-theme/src/global-reset.ts | Reuses shared font-loading helper and re-exports font URL. |
| packages/nano-theme/src/fonts.ts | Adds shared Google Fonts URL and idempotent loader. |
| packages/mutxt-react/src/MuTxt/state/DocumentMenu.tsx | Applies currentColor fill to the light theme icon. |
| packages/mutxt-react/src/MuTxt/MuTxt.tsx | Wraps MathLive virtual keyboard container assignment in safe try/catch. |
| packages/mutxt-react/src/MuTxt/components/blocks/TwoColumnsElement.tsx | Updates two-column block margin styling. |
| packages/mutxt-react/src/MuTxt/components/blocks/PreformattedElement.tsx | Updates preformatted block margin styling. |
| packages/mutxt-react/src/MuTxt/components/blocks/ParagraphElement.tsx | Updates paragraph margin styling. |
| packages/mutxt-react/src/MuTxt/components/blocks/ListElement.tsx | Updates list and list item margin styling. |
| packages/mutxt-react/src/MuTxt/components/blocks/BlockquoteElement.tsx | Updates blockquote margin styling. |
| packages/mutxt-react/src/MuTxt/block/callout/settings.tsx | Wraps note icon to force currentColor path fill. |
| packages/mutxt-react/src/MuTxt/block/callout/CalloutElement.tsx | Updates callout body margin styling. |
| const needsHost = displayMode === 'fullwindow' || displayMode === 'fullscreen'; | ||
| const next = needsHost && mathKbdHostEl ? mathKbdHostEl : document.body; | ||
| vk.container = next; | ||
| // MathLive throws when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.