Skip to content

Add user_id to DeploymentRequest#4

Draft
Copilot wants to merge 4 commits intodevelopfrom
copilot/add-user-id-deployment-request
Draft

Add user_id to DeploymentRequest#4
Copilot wants to merge 4 commits intodevelopfrom
copilot/add-user-id-deployment-request

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 28, 2026 •
edited
Loading

Adds user_id to DeploymentRequest so deployments can be attributed to a specific user end-to-end.

Changes

  • Proto (proto-internal/.../service.proto): Added string user_id = 3 to DeploymentRequest (shifting name→4, deployment_request→5, api_key→6)
  • Generated code (pb/.../service.pb.go): Regenerated with new field and GetUserId() accessor
  • gRPC handler (grpc/services/hosted.go): Logs user_id on deploy request/completion; passes it to the deployer
  • Deployer interface (k8s/deployer/deployer.go): Added userID param to Deploy signature
  • SinkSqlFromProto (k8s/deployer/sink_sql_from_proto.go): Accepts userID and applies it as a user-id Kubernetes label on the StatefulSet
message DeploymentRequest {
  string deployment_id    = 1;
  string organization_id  = 2;
  string user_id          = 3; // new
  string name             = 4;
  sf.hosted.common.v1.DeploymentRequest deployment_request = 5;
  string api_key          = 6;
}

Copilot AI linked an issue Apr 28, 2026 that may be closed by this pull request
Add user_id in DeploymentRequest #3
Open
Copilot AI changed the title [WIP] Add user_id in DeploymentRequest Add user_id to DeploymentRequest Apr 28, 2026
Copilot AI requested a review from billettc April 28, 2026 14:10
@billettc
Copy link
Copy Markdown
Collaborator

billettc commented Apr 28, 2026

pull develop branch so the ci is run again

billettc
billettc requested changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@billettc billettc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull develop branch the do the modification

Comment thread proto-internal/sf/hosted/service/v1/service.proto Outdated
string name = 3;
sf.hosted.common.v1.DeploymentRequest deployment_request = 4;
string api_key = 5;
string user_id = 6;
Copy link
Copy Markdown
Collaborator

@billettc billettc Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make string user_id = 3
;

Copy link
Copy Markdown
Author

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in d1ad074. user_id is now field 3, with name→4, deployment_request→5, api_key→6. Also merged the develop branch as requested.

Copilot AI and others added 2 commits April 28, 2026 14:35
Merge remote-tracking branch 'origin/develop' into copilot/add-user-i…
ac7b64e 
…d-deployment-request

Co-authored-by: billettc <16710840+billettc@users.noreply.github.com>
@billettc
Merge develop branch and move user_id to field 3 in DeploymentRequest
d1ad074 
Agent-Logs-Url: https://github.com/streamingfast/services-control-plane/sessions/9fafab0a-050d-4d89-9692-e4a61f23be06

Co-authored-by: billettc <16710840+billettc@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Apr 28, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Copilot AI requested a review from billettc April 28, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billettc billettc Awaiting requested review from billettc

Assignees

@billettc billettc

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add user_id in DeploymentRequest

2 participants

@billettc