Conversation
…ut for which we can validate we can skip this block. Migrate `ClockDistributor` implementation to `pipeline/distributor`, refactor pipeline integration, and introduce `ExecutorPath` for enhanced module execution tracking.
…mance metrics tracking
…cache management
…` for clarity and consistency across pipeline components.
…per cleanup of WASM modules, and update `tier1` and `tier2` services for compatibility.
…e accurate block skipping based on input sources, stores, and executer indices.
maoueh
reviewed
Apr 13, 2026
…erval validation, and update `tier1` and `tier2` services to handle disabled cache scenarios
sduchesneau
approved these changes
Apr 13, 2026
Contributor
sduchesneau
left a comment
sduchesneau
left a comment
There was a problem hiding this comment.
LGTM, just a few cosmetics suggested
| } | ||
|
|
||
| func (a *Tier2App) Run() error { | ||
| ctx := context.Background() |
Contributor
There was a problem hiding this comment.
This context is only given to the moduleCache, but nothing cancels it or anything.
Why is it declared here ?
| key := moduleKey{binaryIndex: module.BinaryIndex, binaryType: code.Type} | ||
|
|
||
| moduleHashStart := time.Now() | ||
| moduleHash := p.execGraph.ModuleHashes()[module.Name] |
Contributor
There was a problem hiding this comment.
seems weird to ask specifically for '[module.Name]' but then discard it.
These 2 lines would be more readable with:
_ = p.execGraph.ModuleHashes() // memoize
| return strings.TrimPrefix(out, protoPkfPrefix), nil | ||
| } | ||
| func NewTier1( | ||
| ctx context.Context, |
Contributor
There was a problem hiding this comment.
same comment as for Tier2: passing a ctx here and not using it (dead code, misleading)
either the app has a context that it will cancel, either we don't pass down the context and we have a context.Background() used directly inside the cache.
…orage` to v1.59.1; use `zapx.HumanDuration` for improved logging in `tier2`
…ex to avoid out of bound panic
…ier2, because of how tier1's loadbalancer selector sends tcp opens
…t`, ensure accurate TTL-based evictions, and update access timestamps on cache hits.
…nd `tier2` services; simplify WASM module management and update dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.