Conversation
|
Ty for taking the initiative on this. After playing around with the branch I think this is a definite improvement in jank reduction. I'm wondering however if we should try to tackle the 1 remaining piece of jank that you mentioned. Theoretically we should be able to make |
|
I think we should have QA play with this PR. This touches a lot of high risk areas. Especially the |
| hideStyleBlockers: options.hideStyleBlockers, | ||
| }); | ||
| this.setWindowTitle(); | ||
| window.addEventListener('resize', this.windowSizeHandler); |
There was a problem hiding this comment.
It seems a little complex to be adding and removing the resize listener every time we mount and unmount a component to the window. Is the a reason we can't just have the the resize handler mount when the ChildWindow component mounts and just keep it there?
There was a problem hiding this comment.
using the vue lifecycle methods was giving me some extremely weird bugs when i was testing that out, so this was the closest compromise i could find
There was a problem hiding this comment.
Hmm. Could be related to the fact that we are hiding the window without destroying it.
|
Code Climate has analyzed commit be24c5c and detected 0 issues on this pull request. View more on Code Climate. |
This PR does a couple things--
Slight side effect that when resizing a child window the preview on the main window will also be blocked from displaying which is a little weird but overall a much smoother experience. Might be worth isolating the style-blocking elements on a per-window basis in a future iteration