Add test for input/output audio devices#1686
Merged
sandboxcoder merged 3 commits intostagingfrom May 5, 2026
Merged
Conversation
any call the invokes the background osn::startWorker() will now always be released at the end of the test to ensure each test run does not produce an orphaned worker thread if there is an error
|
|
||
| afterEach(async function() { | ||
| // Destroying created outputs and encoders in case the test failed before they were destroyed in the test itself | ||
| const streamEncoder = recording?.videoEncoder; |
Collaborator
There was a problem hiding this comment.
This cleanup only releases recording?.videoEncoder, but in the test Start advanced replay buffer - Use Stream through Recording the encoder is assigned to stream.videoEncoder and the JS recording.videoEncoder wrapper is never set. Please capture and release stream?.videoEncoder as well.
Collaborator
There was a problem hiding this comment.
Additionally, I wonder why you chose this naming in:
const streamEncoder = recording?.videoEncoder;The name streamEncoder assumes that all video encoders assigned to recording are used for streaming. Is it generally true?
Contributor
Author
There was a problem hiding this comment.
Good catch, addressed in commit fbe7d15, thanks
aleksandr-voitenko
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OBS_settings_getOutputAudioDevices&OBS_settings_getInputAudioDevicesMotivation and Context
Aiming for better code coverage
How Has This Been Tested?
Ran locally and on CI build machine
Types of changes
Checklist: