plugins.brightcove: support for HLS stream URLs with query strings + RTMPE stream URLs - #790
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
=======================================
Coverage 48.78% 48.78%
=======================================
Files 76 76
Lines 6188 6188
=======================================
Hits 3019 3019
Misses 3169 3169Continue to review full report at Codecov.
|
Member
|
Cool looks good, thanks :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides small improvements for the BrightcovePlayer class, required for a plugin I'm currently writing to support bfmtv.com.
support for HLS playlist URLs with query strings.
For example, with the account ID 5067014665001 and the player ID 5080870408001, the API returns the following data:
{ [...] "account_id": "5067014665001", "sources": [ { "avg_bitrate": null, "width": null, "src": "https://rmcsporthdslive-lh.akamaihd.net/i/DVMR_BFMSPORT@182576/master.m3u8?__nn__=5078103454001&hdnea=st=1492124400~exp=1492128000~acl=/i/*~hmac=83b8f65edb5480d9cd997c203f0e1809353d0d9e2f166252775c7f31fc9545cc", "size": 0, "height": null, "duration": -1, "container": "M2TS", "codec": "H264", "asset_id": "5080888428001" }, { "avg_bitrate": null, "width": null, "src": "http://rmcsporthdslive-lh.akamaihd.net/z/DVMR_BFMSPORT@182576/manifest.f4m?__nn__=5078103454001&hdnea=st=1492124400~exp=1492128000~acl=/z/*~hmac=52b50e23396bf819e557cc6fab1e49e0944f78ebfe79c95e89769e34617aa900", "size": 0, "height": null, "duration": -1, "container": "MP4", "codec": "H264", "asset_id": "5080888429001" } ], "name": "LIVE BFM Sport", [...] "id": "5080870408001", [...] }support for RTMPE streams.
For example, with the account ID 1969646226001 and the player ID 5393084243001, the API returns the following data:
{ [...] "account_id": "1969646226001", "sources": [ { "avg_bitrate": 512000, "width": 480, "duration": 2904095, "size": 187337224, "stream_name": "mp4:23/1969646226001/201704/3218/1969646226001_5393113723001_5393084243001.mp4", "codec": "H264", "asset_id": "5393113723001", "container": "MP4", "height": 270, "app_name": "rtmpe://cp101677.edgefcs.net/ondemand" }, { "avg_bitrate": 994000, "width": 640, "duration": 2904095, "size": 362560618, "stream_name": "mp4:23/1969646226001/201704/3218/1969646226001_5393114353001_5393084243001.mp4", "codec": "H264", "asset_id": "5393114353001", "container": "MP4", "height": 360, "app_name": "rtmpe://cp101677.edgefcs.net/ondemand" }, [...] ], "name": "LA CITE DISPARUE DE POMPEI", [...] "id": "5393084243001", [...] }